This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: TAB*, NL*, BS* etc in <sys/ioctls.h> in GNU/Hurd and GNU/BSD

> +#define			TAB3	0x00000c00
>  #define		XTABS		0x00000c00	/* expand tabs on output */

Old BSD never had a TAB3.  Since TAB3 really means XTABS, if you define it
at all, use XTABS in the rhs.

> +#if defined __USE_MISC || defined __USE_XOPEN
[...]
> +# define TAB3	(3 << 10)	/* Expand tabs to spaces.  */

We already have the OXTABS [__USE_BSD] that means this.  That should be the
value of TAB3.  Since there is really no TAB3 in the BSD compat defines,
there is no conflict with using that value.  __USE_BSD is a subset of these
conditions, so TAB3 will always be defined.  Use TAB3 in the rhs of OXTABS.

Now would be a good time to double-check that all the bits/termios.h values
are aligned with the BSD values.  e.g. 
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/termios.h?rev=1.29&content-type=text/x-cvsweb-markup

The bits/ioctls.h values should match BSD's sys/ioctl_compat.h.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]