This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Updated x86-64 memcpy and New x86-64 memset


On Sat, Aug 25, 2007 at 11:36:45AM -0700, Evandro Menezes wrote:
> Ulrich,
> 
> > You compare (in memcpy) what is larger:
> > 
> >   __x86_64_core_cache_size_half
> >   _x86_64_data_cache_size_half
> > 
> > The result is never going to change.  Therefore this should be done in
> > the cacheinfo initialization.  If one of the vars is never used
> > otherwise remove it (I haven't checked it).
> 
> The way I wrote the initialization code, if a cache topology is absent its corresponding variable has a value of zero.
> 

memcpy change is incorrect. I got

tst-chk2.c:(.text+0x52f): undefined reference to `__mempcpy_chk'
tst-chk2.c:(.text+0x7f0): undefined reference to `__mempcpy_chk'
tst-chk2.c:(.text+0x3a71): undefined reference to `__mempcpy_chk'
tst-chk2.c:(.text+0x3e0b): undefined reference to `__mempcpy_chk'
collect2: ld returned 1 exit status

H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]