This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] getaddrinfo() dest. addr. selection Rule 7 bugfix


Sridhar Samudrala wrote:
> I thought of doing this. Currently __check_pf() is called once for each
> getaddrinfo() call before we get the list of destination addresses.
> The new RTM_GETROUTE call needs to be done after we get the destination
> address list and once for each dest. address.

And?  Why should this be a problem with reusing the socket?  It's a lame
excuse for not wanting to do the work.


> Are you suggesting using the same socket for RTM_GETROUTE and
> SIOCGHWADDR calls.

No, I did not.  I suggest, though, to use the same socket for all
necessary SIOCGHWADDR calls.


> Can we do a SIOCGHWADDR ioctl on a netlink socket?

I don't know.  I didn't suggest using the ioctl.


> I am not fully familiar with the glibc coding standards, but i tried to
> follow the syntax of the existing code as much as possible.

Then you did an extremely poor job.  Most lines you didn't copy from
somewhere are wrong.


> I think it will be much easier for you to make these changes to fix this
> issue and treat this as a bug report with a suggested solution.

Then say from the beginning that you're not interested in fixing the
problem and have me waste time by explaining them.

-- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â

Attachment: signature.asc
Description: OpenPGP digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]