This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PPC32 factor context functions into and command and fpu/nofpu parts
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Steven Munroe <munroesj at us dot ibm dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Mon, 12 Dec 2005 23:01:47 -0800
- Subject: Re: [PATCH] PPC32 factor context functions into and command and fpu/nofpu parts
- References: <20051103214813.8A86F1809DC@magilla.sf.frob.com> <439CF6B9.70805@us.ibm.com>
Steven Munroe wrote:
* sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/getcontext.S:
New file.
Why create a fpu subdir? The default is with fpu, the nofpu subdir
takes care of the rest.
+#else
+#include "getcontext-common.S"
+#endif
Indentation...
+#if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_3_4)
+ compat_text_section
+
+#undef __CONTEXT_FUNC_NAME
+#define __CONTEXT_FUNC_NAME __novec_getcontext
+#undef __CONTEXT_ENABLE_VRS
Indentation...
and many, many more cases
+ mr 4,3
+ li 3,0
+ li 5,_UC_SIZE_2_3_4;
Use consistently rN instead of just N.
+#define _UC_SIZE 1184
Why is this defined? It is not used.
+#define _UC_SIZE_2_3_4 1184
There is no appropriate extension to the TESTS macro. Do you think we
add these tests for fun?
--
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â