This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] vDSO submission for ppc/ppc64
- From: Tom Gall <tom_gall at vnet dot ibm dot com>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: Tom Gall <tom_gall at vnet dot ibm dot com>, libc-alpha at sources dot redhat dot com
- Date: Thu, 3 Nov 2005 13:47:49 -0600 (CST)
- Subject: Re: [PATCH] vDSO submission for ppc/ppc64
- References: <Pine.LNX.4.64.0511031059280.12351@pacifica> <436A4872.8040501@redhat.com>
On Thu, 3 Nov 2005, Ulrich Drepper wrote:
> Tom Gall wrote:
> > Haven't seen any comments on the last patch, is it truely possible this
> > code isn't all that bad?
>
> The formatting, as always in code you write, is completely wrong. You
> must adjust all this.
Happy to. I presume you want Gnu style as compared to Whitesmith? I'm
presuming http://www.gnu.org/prep/standards/standards.html#Formatting is
the chapter and verse of interest here.
> Second, I won't look at the code until I can test it, i.e., I have a
> kernel which supports this functionality. Tell me when it's in the
> upstream kernel. Then I'll try our next rawhide kernel.
The kernel portion for the gettimeofday vDSO has been upstream since
2.6.11. Ben is working on rest and I plan to pester him mercilessly and
threaten to buy him several beverages of his choice next time I see him,
hopefully at OLS, until he capitulates.
Regards,
Tom
> --
> ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
>
>