This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add sparc64 tls and nptl support

From: Ulrich Drepper <drepper at redhat dot com>
To: "David S. Miller" <davem at davemloft dot net>
Cc: Roland McGrath <roland at redhat dot com>, jakub at redhat dot com, libc-alpha at sources dot redhat dot com, ebotcazou at libertysurf dot fr
Date: Thu, 14 Apr 2005 11:51:39 -0700
Subject: Re: [PATCH] Add sparc64 tls and nptl support
Organization: Red Hat, Inc.
References: <20050414053417.GF14137@sunsite.mff.cuni.cz> <200504140715.j3E7F8j0009531@magilla.sf.frob.com> <20050414111443.411d52ed.davem@davemloft.net>

>  
> +static bool nontls_init_tp_called;

This is not acceptable.  You are adding something for all architectures
even though you need it only on SPARC.  At the very least make
tls_init_tp_called a macro expanding to zero for all existing cases.


-- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â

Attachment: signature.asc
Description: OpenPGP digital signature

Follow-Ups:
- Re: [PATCH] Add sparc64 tls and nptl support
  - From: David S. Miller
- acct() wrongly has __nonnull((1)) in glibc 2.3.5
  - From: Michael T Kerrisk

References:
- Re: [PATCH] Add sparc64 tls and nptl support
  - From: Jakub Jelinek
- Re: [PATCH] Add sparc64 tls and nptl support
  - From: Roland McGrath
- Re: [PATCH] Add sparc64 tls and nptl support
  - From: David S. Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]