Re: [PATCH] sys/kd.h should undefine _LINUX_TYPES_H if it set it.

[Jeremy Huddleston <eradicator at gentoo dot org>]

On Mon, 2005-03-07 at 09:51 -0800, Ulrich Drepper wrote: 
> Jeremy Huddleston wrote:
> > With linux-2.6.10 headers and glibc-2.3.4, the following code will fail:
> > #include <sys/kd.h>
> > #include <linux/byteorder/big_endian.h>
> 
> You cannot mix kernel headers and libc headers.

This patch causes the same behavior as currently exists in sys/sysctl.h.
This behavior is safe.  Additionally, not doing this causes bigendian
machines to fail compilation of xorg-x11 as
xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_KbdMap.c needs to
pull in linux/keyboard.h which eventually pulls in
linux/byteorder/big_endian.h which pulls in linux/types.h (or rather
doesn't because of the sys/kd.h behavior).  Because it doesn't get
types.h, it doesn't have __le64 defined, so parse fails in big_endian.h.

I don't see an easy way around this for xorg-x11, but there is an easy
way around this in glibc with precedent for this workaround existing in
sys/sysctl.h

--jeremy

Attachment: signature.asc
Description: This is a digitally signed message part