This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [regex] BZ #522 Enable UTF-8 and ASCII optimizations outsideglibc, take 2
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- Cc: libc-alpha at sources dot redhat dot com, bruno at clisp dot org
- Date: Mon, 08 Nov 2004 14:21:24 -0800
- Subject: Re: [regex] BZ #522 Enable UTF-8 and ASCII optimizations outsideglibc, take 2
- Organization: Red Hat, Inc.
- References: <418F4646.9010706@lu.unisi.ch>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch is not correct.
First, you introduce additional work in the glibc path. There is no
need to check for UTF8, we know it is UTF-8.
Second, the dfa->mb_cur_max == 6 test does not necessarily apply to all
platforms. It should be removed outside of glibc.
In fact, the glibc code should stay as is.
You also introduced an inconsistency: the regex_internal code uses
isascii() while you explicitly test for <= 127.
I made these changes and applied the patch.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBj/Fk2ijCOnn/RHQRArBOAKCcA8g83e/Q02CLjSHBR1Hh/zKQAgCgyagU
G7L4/QvCerGa1vsZGCTwAiY=
=51CC
-----END PGP SIGNATURE-----