This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix elf/ldd.bash.in syntax errors


Petter Reinholdtsen <pere@hungry.com> writes:

> [Mike Frysinger]
>> @@ -103,7 +104,7 @@
>>  add_env="$add_env LD_LIBRARY_VERSION=\$verify_out"
>>  add_env="$add_env LD_VERBOSE=$verbose"
>>  if test "$unused" = yes; then
>> -  add_env="$add_env LD_DEBUG="$LD_DEBUG${LD_DEBUG:+,}unused"
>> +  add_env="$add_env LD_DEBUG="$LD_DEBUG${LD_DEBUG:+,}unused""
>
> Don't you need some escaping in front of the inner quotes?  Something
> like this?
>
>   add_env="$add_env LD_DEBUG=\"$LD_DEBUG${LD_DEBUG:+,}unused\""

Or for later evaluation of $LD_DEBUG:

    add_env="$add_env LD_DEBUG=\${LD_DEBUG:+\$LD_DEBUG,}unused"

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]