This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: statvfs64 does not work as expected
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: Thorsten Kukuk <kukuk at suse dot de>, libc-alpha at sources dot redhat dot com
- Date: Sat, 3 Apr 2004 12:46:15 +0200
- Subject: Re: statvfs64 does not work as expected
- References: <20040323091204.GA7370@suse.de> <20040402121721.GA23510@suse.de> <406E6CCD.3050605@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Apr 02, 2004 at 11:50:37PM -0800, Ulrich Drepper wrote:
> Thorsten Kukuk wrote:
>
> > Attached is a try from me to fix this.
>
> It's not correct. There are several problems. Like not fixing
> fstatvfs64, not taking into account the fstatfs64 is guaranteed. I've
> checked in a patch which should fix all these things.
I believe duplicating full internal_statvfs is unnecessary, more than 50% of
that routine is about computing buf->f_flag from name, st and fsbuf->f_type.
So I think we should move that code into a separate routine, which would
be called by both internal_statvfs{,64}.
And we need linux/wordsize-64/internal_statvfs64.c as empty file to avoid
bloating 64-bit arches.
Jakub