This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Sysdeps changes for hppa.
- From: Ulrich Drepper <drepper at redhat dot com>
- To: "Carlos O'Donell" <carlos at baldric dot uwo dot ca>
- Cc: libc-alpha <libc-alpha at sources dot redhat dot com>, parisc-linux at lists dot parisc-linux dot org
- Date: Tue, 14 Oct 2003 22:49:10 -0700
- Subject: Re: [PATCH] Sysdeps changes for hppa.
- Organization: Red Hat, Inc.
- References: <20031012213226.GE23999@systemhalted>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> 2003-10-12 Carlos O'Donell <carlos@baldric.uwo.ca>
>
> * sysdeps/hppa/sysdep.h: Undef JUMPTARGET before use.
> * sysdeps/unix/sysv/linux/hppa/sysdep.h:
> Define __NR_semtimedop for compat with old kernels,
> PSEUDO_ERRVAL, SYSCALL_ERROR_LABEL under all conditions,
> INTERNAL_SYSCALL_DECL, INTERNAL_SYSCALL_ERROR_P,
> INTERNAL_SYSCALL_ERRNO, INTERNAL_SYSCALL, and undef
> JUMPTARGET before use.
> [PIC]: Save pic register around syscall.
> * sysdeps/unix/sysv/linux/hppa/sysdep.c (syscall):
> Cleanup asm statment.
I've applied this patch, but only because I really don't care how the PA
port looks.
The semtimedop definition is completely wrong. If you want all
syscall,s use appropriate headers.
You've modified the patch by hand and broke it, forcing me to do clean up.
The coding style is completely wrong and a terrible mess. The coding
standard document is available, read it.
The preprocessor directive indentation is wrong or non-existing.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/jN/W2ijCOnn/RHQRAjrzAJsEI3ukb5MQ/T0Wl0ihUX1l2ejBJACeL8GW
7tzXLthx8pW4Rhb+26NQkH4=
=8Fy5
-----END PGP SIGNATURE-----