This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linuxthreads for hppa (1/3)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I think I've asked this before:

> 	Use __LT_INITIALIZER_NOT_ZERO instead of __LT_SPINLOCK_INIT.

Why?  No unnecessary changes.


guardaddr))
> +#  else
>    while (h->h_descr == NULL
> -	 || ! (sp <= (char *) h->h_descr->p_stackaddr && sp >= h->h_bottom))
> +	 || ! (sp <= (char *) h->h_descr->p_stackaddr && sp >= (char *) h->h_bottom))
> +#  endif

No unnecessary changes.  Leave the code you're not using alone.


>      h++;
>  # else
> -  while (! (sp <= (char *) h->h_descr && sp >= h->h_bottom))
> +#  ifdef _STACK_GROWS_UP

And again.


- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/jNd02ijCOnn/RHQRAl6CAJ0Tv6yItJOX52RZu71GKSrGFUfMtACgnf6i
Jy0mt+OERsR8N35JOFozwPU=
=kNiu
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]