This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
- From: Carlos O'Donell <carlos at baldric dot uwo dot ca>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: libc-alpha at sources dot redhat dot com, debian-glibc at lists dot debian dot org,Alan Modra <amodra at bigpond dot net dot au>
- Date: Wed, 25 Sep 2002 13:32:46 -0400
- Subject: Re: [PATCH] glibc 2.2.94 - hppa - revised plt relocation patch
- References: <20020925170306.GB14672@systemhalted> <20020925100553.A14081@lucon.org>
> > diff -urN libc/elf/do-rel.h libc/elf/do-rel.h
> > --- libc/elf/do-rel.h 18 Sep 2002 18:28:43 -0000
> > +++ libc/elf/do-rel.h 23 Sep 2002 11:35:14 -0000
> > @@ -30,6 +30,12 @@
> > # define RELCOUNT_IDX VERSYMIDX (DT_RELCOUNT)
> > #endif
> >
> > +#ifndef DO_ELF_MACHINE_REL_RELATIVE
> > +#define DO_ELF_MACHINE_REL_RELATIVE(map, l_addr, reloc) \
> > + elf_machine_rel_relative (l_addr, reloc, \
> > + (void *) (l_addr + relative->r_offset))
^^^^^^^^
reloc
> > +#endif
> > +
>
> Where does `relative' come from? Why not add it to the arg?
> H.J.
>
Cut-n-paste mistake.
o Alan Modra handed me a prototype patch to test, and I did
just that. The fact that I didn't notice this was due to idiocy :}
o It's also my mistake for not waiting to test the patches on
the other build machines I have (Alpha / i386 / PowerPC-32).
o The patch _is_ applied, and is part of the PA chroot that I have
tested within. The fact that it doesn't have detremental effects
is rather disconcerting.
I'll make the required change and repost.
c.