Re: [PATCH] memset.S for PowerPC

[Geoff Keating <geoffk at geoffk dot org>]

> Date: Thu, 22 Aug 2002 10:02:42 -0500
> From: Steven Munroe <sjmunroe@vnet.ibm.com>

> Here is the revised memset patch for PowerPC (32-bit). 
> 
> 2002-08-20  Steven Munroe  <sjmunroe@us.ibm.com>
> 
>   * sysdeps/powerpc/elf/libc-start.c 
>   (__cache_line_size): Declare.
>   (__aux_init_cache): New.
>   (__libc_start_main): Change type of `auxvec' parameter to
>   `ElfW(auxv_t) *'.  Correct walking of aux vector.  Call
>   __aux_init_cache.
>   * sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c 
>   (__cache_line_size): Declare.
>   (__aux_init_cache): New.
>   (DL_PLATFORM_INIT): Define.
>   * sysdeps/powerpc/memset.S: Define __cache_line_size and use its
>   value to select the correct stride for dcbz.

This is OK (except that ChangeLog entries get indented by one tab),
and I've committed it to mainline with that correction.  If others
(Andreas?) want to commit it to the 2.2 branch they should feel free.

More advice: 

- The patch seems to have been relative to 2.2.5, which turns out to be
  little difference for this patch but in future it'd be better to make
  patches relative to the current CVS version.

- You should get a sourceware account, so you can commit your own
  patches.  Go to <http://sources.redhat.com/cgi-bin/pdw/ps_form.cgi>,
  and fill in the form.  

  It might help to read the instructions at
  <http://gcc.gnu.org/cvswrite.html>; these are for GCC, but the setup
  for glibc is very similar, the main changes are that it's
  `sources.redhat.com' not `gcc.gnu.org' and `/cvs/glibc' not
  `/cvs/gcc'.

Congratulations!  I assure you, the first patch is the hardest.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>