This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Problem with VMware 2.0.4 and glibc 2.2.5
On Wed, Apr 10, 2002 at 06:20:10PM +0200, Thorsten Kukuk wrote:
> > It looks like glibc 2.2.5 changed the ABI for nice. Shouldn't we give
> > it a new version?
>
> With such a change an the fact, that the old, wrong behaviour is
> descriped in nearly every Linux documentation which contains a
> description for nice, Yes, we should give it a new version.
Here is a patch.
>
> Thorsten
>
> PS: I didn't hear anything about my nice patch, which makes the current
> implementation really correct?
May I suggest to add a testcase at the same time?
H.J.
---
2002-04-10 H.J. Lu <hjl@gnu.org>
* resource/Versions (nice): Added to GLIBC_2.2.5.
* sysdeps/unix/sysv/linux/nice.c: Marked it for GLIBC_2.2.5.
* sysdeps/unix/sysv/linux/syscalls.list (oldnice): Added for
GLIBC_2.0.
--- glibc-2.2.5/resource/Versions.nice Tue Jan 4 08:11:53 2000
+++ glibc-2.2.5/resource/Versions Wed Apr 10 10:20:35 2002
@@ -22,4 +22,8 @@ libc {
# s*
setrlimit64;
}
+ GLIBC_2.2.5 {
+ # The new nice interface
+ nice;
+ }
}
--- glibc-2.2.5/sysdeps/unix/sysv/linux/nice.c.nice Wed Mar 13 04:52:29 2002
+++ glibc-2.2.5/sysdeps/unix/sysv/linux/nice.c Wed Apr 10 10:31:37 2002
@@ -1 +1,5 @@
+#define nice __new_nice
#include <sysdeps/unix/nice.c>
+#undef nice
+#include <shlib-compat.h>
+versioned_symbol (libc, __new_nice, nice, GLIBC_2_2_5);
--- glibc-2.2.5/sysdeps/unix/sysv/linux/syscalls.list.nice Fri Apr 20 13:49:19 2001
+++ glibc-2.2.5/sysdeps/unix/sysv/linux/syscalls.list Wed Apr 10 10:04:03 2002
@@ -31,6 +31,7 @@ mremap EXTRA mremap b:aini __mremap mr
munlock - munlock i:ai munlock
munlockall - munlockall i: munlockall
nanosleep - nanosleep i:pp __libc_nanosleep __nanosleep nanosleep
+oldnice EXTRA nice i:i __old_nice nice@GLIBC_2.0
nfsservctl EXTRA nfsservctl i:ipp nfsservctl
pause - pause i: __libc_pause pause
personality init-first personality i:i __personality personality