This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH: Re: Do we really want to use i586 code for i686?


On Sun, Nov 11, 2001 at 08:59:25AM -0800, H . J . Lu wrote:
> sysdeps/i386/i686/Implies says:
> 
> # Due to the reordering and the oher nifty extensions in the i686 it is
> # not really good to use heavily i586 optimized code on a i686.  It's
> # better to use i486/i386 code.
> i386/i486
> 
> But I got:
> 
> /home/hjl/work/gnu/src/glibc/libc/configure \
> 	i686-linux  \
> 	--prefix=/usr \
> 	--without-cvs \
> 	--enable-add-ons=linuxthreads
> creating cache ./config.cache
> checking host system type... i686-pc-linux-gnu
> checking sysdep dirs... sysdeps/i386/elf linuxthreads/sysdeps/unix/sysv/linux/i386 linuxthreads/sysdeps/unix/sysv/linux linuxthreads/sysdeps/pthread sysdeps/pthread linuxthreads/sysdeps/unix/sysv linuxthreads/sysdeps/unix linuxthreads/sysdeps/i386/i686 linuxthreads/sysdeps/i386/i586 sysdeps/i386/i586 sysdeps/i386/i486 linuxthreads/sysdeps/i386/i486 linuxthreads/sysdeps/i386 sysdeps/unix/sysv/linux/i386/i686 sysdeps/unix/sysv/linux/i386 sysdeps/unix/sysv/linux sysdeps/gnu sysdeps/unix/common sysdeps/unix/mman sysdeps/unix/inet sysdeps/unix/sysv/i386/i686 sysdeps/unix/sysv/i386 sysdeps/unix/sysv sysdeps/unix/i386/i686 sysdeps/unix/i386 sysdeps/unix sysdeps/posix sysdeps/i386/i686/fpu sysdeps/i386/i686 sysdeps/i386/fpu sysdeps/i386 sysdeps/wordsize-32 sysdeps/ieee754/ldbl-96 sysdeps/ieee754/dbl-64 sysdeps/ieee754/flt-32 sysdeps/ieee754 sysdeps/generic/elf sysdeps/generic
> 
> and
> 
> $(common-objpfx)stdlib/sub_n.o $(common-objpfx)stdlib/sub_n.os $(common-objpfx)stdlib/sub_n.op $(common-objpfx)stdlib/sub_n.og $(common-objpfx)stdlib/sub_n.ob $(common-objpfx)stdlib/sub_n.oS $(common-objpfx)stdlib/sub_n.d: ../sysdeps/i386/i586/sub_n.S ../include/libc-symbols.h \
>   $(common-objpfx)config.h \
>   ../sysdeps/unix/sysv/linux/i386/i686/sysdep.h \
>   ../sysdeps/unix/sysv/linux/i386/sysdep.h ../sysdeps/unix/i386/sysdep.h \
>   ../sysdeps/unix/sysdep.h ../sysdeps/generic/sysdep.h \
>   ../sysdeps/unix/sysv/linux/sys/syscall.h /usr/include/asm/unistd.h \
>   ../sysdeps/i386/sysdep.h ../sysdeps/generic/bp-sym.h \
>   ../sysdeps/i386/bp-asm.h ../sysdeps/i386/asm-syntax.h
> 
> I think the problem may be linuxthreads/sysdeps/i386/i686/Implies:
> 
> i386/i586
> 
> 

How about this patch?


H.J.
----
2001-11-11  H.J. Lu  <hjl@gnu.org>

	* configure.in: Limit addon's Implies to addon only.
	* configure: Rebuild.

--- configure.in.addon	Sun Nov 11 16:45:00 2001
+++ configure.in	Sun Nov 11 16:45:11 2001
@@ -799,7 +799,7 @@ while test $# -gt 0; do
 	implied="$implied $name_base/$x";
 	found=yes
       fi
-      for d in $add_ons_pfx ''; do
+      for d in $add_ons_pfx; do
 	try="${d}sysdeps/$x"
 	case $d in
 	 /*) try_srcdir= ;;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]