This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix EM_S390 value




Hi Andreas,
>Newer binutils use 22 as value for EM_S390.  I hope this is the
>official value.
It is the value I got from Dave Prosser.

>Programs compiled with the new binutils will fail since dl-machine
>checks only for the old value.  The appended patch corrects the value
>and glibc checks now for both values so that glibc will work with old
>and new binutils.
>
>Martin, is this really the official value?  Is the appended patch ok?
The patch looks ok. To get the glibc-2.2.2 working you'll want to have
another patch for pt-initfini.c. The alignment at the end of the function
prologs adds zeros to the instructions stream. Needless to say that this
kills every program that uses the new pthreads.

2001-03-09  Martin Schwidefsky  <schwidefsky@de.ibm.com>

        * linuxthreads/sysdeps/unix/sysv/linux/s390/pt-initfini.c: Use
          0x07 padding for code alignment.

diff -urN
glibc-2.2.2/linuxthreads/sysdeps/unix/sysv/linux/s390/pt-initfini.c
glibc-2.2.2-s390/linuxthreads/sysdeps/unix/sysv/linux/s390/pt-initfini.c
--- glibc-2.2.2/linuxthreads/sysdeps/unix/sysv/linux/s390/pt-initfini.c
Wed Feb  7 02:30:22 2001
+++
glibc-2.2.2-s390/linuxthreads/sysdeps/unix/sysv/linux/s390/pt-initfini.c
Fri Mar  9 17:52:02 2001
@@ -87,7 +87,7 @@
     BASR  14,1
 .L22:
 #APP
-    ALIGN
+    .align 4,0x07
     END_INIT

 /*@_init_PROLOG_ENDS*/
@@ -132,7 +132,7 @@
     L    12,.LC17-.LT2_0(13)
     AR   12,13
 #APP
-    ALIGN
+    .align 4,0x07
     END_FINI

 /*@_fini_PROLOG_ENDS*/

--
By the way I made a glibc-2.2.2 patch for 31bit and 64bit linux/390. It
is big (595818 bytes). What do we need to get it into the official source
tree? A new FSF assignment or can we live with the old one?

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]