[Bug default/19596] Incorrect exit status for incompatible ABI change

["dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19596

--- Comment #1 from dodji at redhat dot com ---
> I just swapped the order of two pure virtual methods in an abstract base class.
> The generated report correctly diagnoses the ABI break, but the exit status
> from abidiff is 4. I was expecting 8 or 12.

Right, it should have been 12.

> Here is the trace from my build driver script:
>
> + abidiff libunity-scopes_1.0.0.abi.xml libunity-scopes_1.0.3.abi.xml
> check-abi-compliance.sh: ABI is compatible with changes, see
> libunity-scopes_1.0.3_abi-report.txt for details.

Hmmh ...

> + status=4

FWIW, the value 4 (named ABIDIFF_ABI_CHANGE) doesn't mean that the two
ABIs are compatible.  It means there is an ABI change, and that change
might or might not make the two ABIs be incompatible.  The change needs
to be reviewed.

With time (and reports like this one) we'll hopefully categorize
incompatible changes more precisely.  That is, more incompatible changes
will trigger the ABIDIFF_ABI_INCOMPATIBLE_CHANGE flag, leaving the
ABIDIFF_ABI_CHANGE flag really for the "gray area" changes that really
need human inspection to ultimately say if they are incompatible or not.

[...]

-- 
You are receiving this mail because:
You are on the CC list for the bug.