This is the mail archive of the kawa@sourceware.org mailing list for the Kawa project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: please try out the Kawa binary pre-release


On 11/03/2016 01:58 AM, Sudarshan S Chawathe wrote:

I noticed a minor problem: The automatic CLASSPATH-setting code in the
'kawa' shell script does not do the intended (I think) thing when that
shell script is invoked as "./kawa" (leading to an error "Could not find
or load main class kawa.repl).  I believe a small change to the sed
command in the kawa script does the trick:

  kawadir=`echo "$thisdir" | sed -e 's|/bin\(/.\)*$||'`

Perhaps it is safe to replace the '*' with a '?', but the above will
cover the case of multiple trailing './' substrings if they somehow
appear.

Thanks!  I checked your fix into Subversion.
With one minor change: I escaped the period:

kawadir=`echo "$thisdir" | sed -e 's|/bin\(/\.\)*$||'`

I am including a context diff below for completeness sake.

For future reference: Most people and projects these days prefer
unified (-u) diffs.  Also note your patch was reversed.
--
	--Per Bothner
per@bothner.com   http://per.bothner.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]