This is the mail archive of the kawa@sourceware.org mailing list for the Kawa project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Testsuite failing




On 07/09/2014 03:02 PM, Per Bothner wrote:


On 07/08/2014 09:24 PM, Matthieu Vachon wrote:
Here a patch that make `testsuite/errors3.scm` pass. The message was
expecting `... with required type int` while it's now `... with
required type character`.

Maybe the code should be fixed and not the test ... not sure about it.

The test us fine.  The problem is the code in kawa.standard.Scheme#formatTest.
Specifically how it enters both T and T.getImplementationType() into the
typeToStringMap.  Thia looses if T is the character type, since the
implementation type for T is int.

I checked in a fix.

(If it wasn't clear: The reason for the Java 7 vs Java 8 inconsistency
isn't anything "real".  Rather it is due to unspecified traversal order
of hash tables.  Somehow Java 8 tweaked the implementation enough so
the bug was hidden on Java 8.)

--
	--Per Bothner
per@bothner.com   http://per.bothner.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]