This is the mail archive of the
kawa@sourceware.org
mailing list for the Kawa project.
Re: Java5 Compilation
- From: Matthieu Vachon <matthieu dot o dot vachon at gmail dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: "kawa at sourceware dot org" <kawa at sourceware dot org>
- Date: Fri, 29 Nov 2013 07:57:32 -0500
- Subject: Re: Java5 Compilation
- Authentication-results: sourceware.org; auth=none
- References: <CAOTvmonVFjz0uaH8Wmw-3LxQ6d8ZUQd3syBQTVfgAF57q+_PzQ at mail dot gmail dot com> <52982C08 dot 5000100 at bothner dot com>
Related to @Override, I saw in the latest commits that methods you
modify are often reformatted with correct indentation et al. Are you
using a particular editor when doing?
I wonder about this because I have an Eclipse project in my fork and
it has problem compiling some parts of the Kawa codebase (mainly parts
about subclass of AbstractWeakHashTable<K, V> complaining on note
implementing some methods). Having a working one could help me package
a bug report for the JDT team.
Moreover, having the code style you are using could refine the one I
have put in my Eclipse project.
On Fri, Nov 29, 2013 at 12:54 AM, Per Bothner <per@bothner.com> wrote:
> On 11/27/2013 09:06 AM, Matthieu Vachon wrote:
>>
>> The current master does not compile on Java 5 due to some @Override
>> statements on methods that implements an interface.
>>
>> This is permitted on Java 6 but result in a compilation error on Java
>> 5. I attached a patch that removes them but there may be a better
>> solution to this.
>
>
> Thanks - I checked this in.
>
> As an alternative we could use PreProcess conditions, but it doesn't seem
> worth it, at least not until we get more consistent about adding @Override.
> --
> --Per Bothner
> per@bothner.com http://per.bothner.com/