This is the mail archive of the
kawa@sourceware.org
mailing list for the Kawa project.
Re: [PATCH] Support CommonLisp in RunTestScript
- From: Per Bothner <per at bothner dot com>
- To: Jamison Hope <jrh at theptrgroup dot com>
- Cc: kawa at sources dot redhat dot com
- Date: Mon, 02 Jul 2012 12:07:54 -0700
- Subject: Re: [PATCH] Support CommonLisp in RunTestScript
- References: <ECDBB7A6-3A47-47E1-A493-0E11775F7B72@theptrgroup.com>
On 07/02/2012 12:00 PM, Jamison Hope wrote:
Resending because I think the last one got lost in the GSOC thread.
Thanks - checked in.
I am still of the opinion that instead of hard-coding these
language-specific
tokens into RunTestScript, it should be able to query the Language
instance for
them (i.e. augment the Language API to include String methods
getBlockCommentStart(), getBlockCommentEnd(), etc).
I agree.
I recognize, though, that
this information is currently implicitly defined in several places in
the reader
classes, and so making such a change right now is too large and intrusive.
Well, I wouldn't expect to change the reader classes. Just add the
methods to the Language classes, and then change RunTestScript.
--
--Per Bothner
per@bothner.com http://per.bothner.com/