This is the mail archive of the kawa@sourceware.org mailing list for the Kawa project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: string-contains and srfi-13


On 12/22/2011 08:50 PM, Jamison Hope wrote:
This is a bug we inherited from the reference implementation. The helper
function
string-parse-start+end is documented to return three values: "rest start
end",
but within make-kmp-restart-vector (which appears about 5 levels down in
your
stack trace) its result is bound to two variables (start end). The same
error
exists in string-kmp-partial-search.

I believe that in both of those places the call to
string-parse-start+end should
be replaced by a call to string-parse-final-start+end, which strips off
the first
unwanted rest value.

Would you mind posting your patch and analysis to srfi-13@srfi.schemers.org ?
That way the patch becomes part of the discussion and record, i.e. the
"Post-Finalization Discussion Archive" linked to from http://srfi.schemers.org/srfi-13/
--
--Per Bothner
per@bothner.com http://per.bothner.com/



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]