This is the mail archive of the
kawa@sources.redhat.com
mailing list for the Kawa project.
RE: Patch for ListPat.java - take 2
- From: "Dominique Boucher" <dominique dot boucher at nuecho dot com>
- To: "'Per Bothner'" <per at bothner dot com>
- Cc: "'Kawa List'" <kawa at sources dot redhat dot com>
- Date: Thu, 19 Aug 2004 22:40:46 -0400
- Subject: RE: Patch for ListPat.java - take 2
- Reply-to: <dominique dot boucher at nuecho dot com>
> > If you apply the proposed patch, JEmacs does not build anymore. In
> > gnu/jemacs/lisp/keymap.el, there is an 'if' expression that
> contains
> > more than 3 arguments. This is perfectly legal [Emacs/Common] Lisp
> > code, but not legal Scheme code...
>
> This code is presumably mis-compiled, since arguments beyond
> 3 are ignored by ifp.java.
That's what I noticed after having sent my previous emails.
> > So I guess there should be a Lisp-specific 'if' special
> form, instead
> > of reusing the Scheme one.
>
> We can add a "allowElseList" boolean in ipf.java, set by the
> constructor. Then we can use VarListPat if allowElseList.
>
> The test 'obj instanceof Pair' in your original patch might
> be better 'obj != LList.Empty' to catch impure lists.
Of course!
Dominique