This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH] use an observer instead of deprecated_file_changed_hook
- From: Keith Seitz <keiths at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>, Insight List <insight at sourceware dot org>
- Date: Tue, 07 Jan 2014 12:03:17 -0800
- Subject: Re: [PATCH] use an observer instead of deprecated_file_changed_hook
- Authentication-results: sourceware.org; auth=none
- References: <871u0jhamf dot fsf at fleche dot redhat dot com>
On 01/07/2014 11:09 AM, Tom Tromey wrote:
I think it works ok. I tested it by running the "file" command in the
console and seeing whether insight reacted. I'm not totally sure
whether this is a sufficient check, though.
With the additional checks you've added in the observer function, this
should work.
The standard test (IIRC -- I haven't tried this in years) is to start
insight on one executable, debug it a bit (run, step, step, step) with
some open data windows, then load an entirely new executable. If that
runs and the displays all show the new executable's state, then all is
probably good. I believe I also then followed with "file" (no
executable), which should simple clear state and "empty" all the windows.
From discussions on IRC, this use case is preserved. So that's good
enough for me.
Thank you for the patch!
Keith