This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH 2/2] Notice architecture changes even when the register window is not open.
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: insight at sourceware dot org
- Cc: "Keith Seitz" <keiths at redhat dot com>
- Date: Fri, 6 Sep 2013 10:37:16 +0100
- Subject: Re: [PATCH 2/2] Notice architecture changes even when the register window is not open.
- Authentication-results: sourceware.org; auth=none
- References: <5228941F dot 8080601 at broadcom dot com> <522894D1 dot 3030209 at broadcom dot com> <5228D4B7 dot 2020908 at redhat dot com>
On 05/09/2013 8:00 PM, Keith Seitz wrote:
> On 09/05/2013 07:27 AM, Andrew Burgess wrote:
>
> One little comment below.
>
>> Index: ./gdb/gdbtk/library/interface.tcl
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
>> retrieving revision 1.60
>> diff -u -p -r1.60 interface.tcl
>> --- ./gdb/gdbtk/library/interface.tcl 9 Oct 2009 01:23:55 -0000
>> 1.60
>> +++ ./gdb/gdbtk/library/interface.tcl 5 Sep 2013 14:19:53 -0000
>> @@ -1815,6 +1815,9 @@ proc initialize_gdbtk {} {
>> # The architecture changed. Inform the UI.
>> proc gdbtk_tcl_architecture_changed {} {
>> set e [ArchChangedEvent \#auto]
>> + # First perform global actions as a result of the architecture change.
>> + gdb_reg_arch_changed $e
>> + # Now dispatch to all the other even handlers.
>
> typo ("even[t] handlers")
Fixed.
>
>> GDBEventHandler::dispatch $e
>> delete object $e
>> }
>
> Okay with that change.
Applied.
Thanks,
Andrew