This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH/gdbtk] Make color of changed vars customizable v2
- From: Roland Schwingel <roland at onevision dot com>
- To: insight at sourceware dot org
- Date: Fri, 25 May 2012 12:41:59 +0200
- Subject: Re: [PATCH/gdbtk] Make color of changed vars customizable v2
Hi ...
Thanks for reviewing Keith!
I applied all your wishes regarding formatting.
> > @@ -54,7 +54,7 @@ itcl::body SrcPref::_build_win {} {
> > set w [$f.colors get_frame]
> >
> > set color [pref get gdb/src/PC_TAG]
> > - label $w.pcl -text {PC}
> > + label $w.pcl -text {PC/Var change}
> > button $w.pcb -text { } -activebackground $color -bg $color
> > -command [code $this _pick $color $w.pcb PC_TAG]
>
> How about if we just use the more generic term, "Highlight"
> instead of "PC/Var change"?
Changed the label to "Highlight". You are right this is the better term.
Committed the patch now.
Roland