This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
RE: [PATCH] print format does not match argument type
- From: "Patrick Monnerat" <Patrick dot Monnerat at datasphere dot ch>
- To: <insight at sourceware dot org>
- Date: Wed, 11 Apr 2012 19:24:11 +0200
- Subject: RE: [PATCH] print format does not match argument type
- References: <4F856D00.70306@onevision.com>
Roland Schwingel wrote:
> %llx appears to work (tested it on win32,win64 and linux 32bit).
> We can even remove the cast at all. I got no warning here.
No warning, but you may have a wrong value converted at run-time: this
is the case if the %llx descriptor uses a value larger than the one that
gets pushed and your're running on a big-endian machine or the bytes
above the pushed value are not zero...
I would really keep the (unsigned long long) cast, at least for run-time
purpose.
> So ok... Who is doing the change?
Not me: I'm not a committer ;-))
Cheers,
Patrick