This is the mail archive of the insight@sourceware.org mailing list for the Insight project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add missing prototype in gdbtk.c

From: Keith Seitz <keiths at redhat dot com>
To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Cc: insight at sourceware dot org
Date: Fri, 30 Mar 2012 06:10:01 -0700
Subject: Re: [PATCH] Add missing prototype in gdbtk.c
References: <4F67221F.2020906@onevision.com> <4F74E9F1.20804@redhat.com> <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr>

On 03/30/2012 06:02 AM, Pierre Muller wrote:

I hope that I found the reason:
Prototypes apparently require (void) instead of ().

That's interesting...

The following patch fixes the problem for mingw32,

Is this patch OK?

Sure, you could consider a clean-up like that obvious. [I try to use the same "rules" gdb uses. It's what I'm used to.]

Thank you, Pierre!

Keith

Follow-Ups:
- RE: [PATCH] Add missing prototype in gdbtk.c
  - From: Pierre Muller

References:
- [PATCH] Add missing prototype in gdbtk.c
  - From: Roland Schwingel
- Re: [PATCH] Add missing prototype in gdbtk.c
  - From: Keith Seitz
- RE: [PATCH] Add missing prototype in gdbtk.c
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]