Re: [PATCH] Fix global preferences

[Roland Schwingel <roland at onevision dot com>]

Hi ...

Keith Seitz <keiths@redhat.com> wrote on 30.03.2012 01:12:23:

> > * library/globalpref.itb (_build_win): Remove unneeded debug call.
> > Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small
> > reformatting.
> >
> > Any comments? Is this ok?
>
> Ok.
Committed this now. Also updated copyright info in file.

> Can I ask you to generate one diff per patch submission instead
> of one diff/attachment per file? It's a little easier to deal with.
Ok. I will do so. As I made more changes all together it was easier
to me to work on file basis. But I can merge them later on again.

> I am really looking forward to trying this all out! [I have a mingw32
> installation somewhere that I randomly get to work, but i haven't
> tried 64-bit yet.]
Yet I haven't sent all needed patches. I first wanted to get the patches 
I have already sent all be in to not loose track what is in and what 
not. If all my patches are in next would be to update iwidgets and itcl. 
If this is done it would be required to update tcl/tk to 8.6 for 64bit 
windows.

From this point on insight could be build for windows 64bit using 
mingw-w64 toolchain and autotools machinery. I have to confess that I am 
at present not building using autotools machinery for myself. I am using 
our own company build system which gives me more flexibility. It uses 
mingw-w64 compilers for both 32 and 64bit windows and the very same 
compiler also for linux. It is also driven by gnu make but has its own 
build rules and project types. I am building ALL needed dependencies 
with it on all platforms. So everything is always all of a piece on all 
platforms. This avoids nearly all system setup specific little problems 
and is also faster. I can build a win32/win64 and linux version each all 
debug and release from full scratch with all needed libraries 
(tcl/tk/expat/zlib/gdb/insight and so on) just within around 9 minutes 
on an older Intel Q6600 cpu.

Before sending out patches to you I am always building with a stock 
mingw32 (and a native OpenSuse 11.4) to avoid any regressions and 
surprises here. At present you can't build for win64 until I am fully 
done with my backmerge. You can build for win32 using mingw32.

Beside of my insight patches I am having a patch pending in tk 8.6 
itself for windows geometry handling (support for dual/multihead) and a 
patch in gdb itself to allow stepping into dll code on windows 64bit.
(for the later I am waiting to get my copyright assignment request 
processed by gnu.)

If you want to test on windows I can also supply you prebuildt binaries 
for both 32 and 64bit windows. Just give me a note.

At present I am having 2 bigger problems left with my insight. One are 
some strange symtab problems when debugging Objective C code using 
insight. This problem is only present within insight not gdb build from 
the very same codebase and I do have sometimes some rare crashes of 
insight and gdb itself on windows which I have to hunt down.

Roland