This is the mail archive of the insight@sourceware.org mailing list for the Insight project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't call Insight hooks when not appropriate

From: Daniel Jacobowitz <drow at false dot org>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>, andrew dot stubbs at st dot com, gdb-patches at sourceware dot org, insight at sourceware dot org
Date: Thu, 9 Mar 2006 14:14:26 -0500
Subject: Re: [PATCH] Don't call Insight hooks when not appropriate
References: <44104BB2.6000108@st.com> <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> <20060309191304.GA31165@nevyn.them.org>

On Thu, Mar 09, 2006 at 02:13:04PM -0500, Daniel Jacobowitz wrote:
> On Thu, Mar 09, 2006 at 08:10:56PM +0100, Mark Kettenis wrote:
> > > Date: Thu, 09 Mar 2006 15:37:22 +0000
> > > From: Andrew STUBBS <andrew.stubbs@st.com>
> > > 
> > > 2006-03-09  Andrew Stubbs  <andrew.stubbs@st.com>
> > > 
> > > 	* cli/cli-script.c (execute_user_command): Set instream to -1, not 0.
> > > 	(read_command_lines): Check instream before calling the prompt hook.
> > 
> > I think this usage of -1 is a bad idea.
> 
> Me too.  We're already using a global variable; why not just add
> another and restore it in the same cleanup?

Or maybe make the existing user_call_depth global.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- [PATCH] Don't call Insight hooks when not appropriate
  - From: Andrew STUBBS
- Re: [PATCH] Don't call Insight hooks when not appropriate
  - From: Mark Kettenis
- Re: [PATCH] Don't call Insight hooks when not appropriate
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]