This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Stop insight from SEGVing?


I thought this was all taken care of but it seems like the below change
is required to get insight working with the new interpreter stuff.  Without
this args.interpreter_p is eventually dereferenced and... boom.

Ok to apply?  The only minor nit that I can think of is that I wasn't
sure if it might not make sense to define "gdbtk" similarly to the way
that INTERP_CONSOLE and INTERP_MI* are currently defined.

(I was >this< close to checking this in as obvious but then I wondered
if I was missing something.)

cgf

2003-02-14  Christopher Faylor  <cgf@redhat.com>

	* generic/gdbtk-main.c (main): Correctly initialize args.interpreter_p.


Index: generic/gdbtk-main.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-main.c,v
retrieving revision 1.1
diff -u -p -r1.1 gdbtk-main.c
--- generic/gdbtk-main.c        26 Sep 2002 17:46:06 -0000      1.1
+++ generic/gdbtk-main.c        15 Feb 2003 04:16:35 -0000
@@ -32,5 +32,6 @@ main (int argc, char **argv)
   args.argc = argc;
   args.argv = argv;
   args.use_windows = 1;
+  args.interpreter_p = "gdbtk";
   return gdb_main (&args);
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]