This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: Why is PASCAL undefined in win/tclWinPort.h?
On Thu, 5 Sep 2002 06:20:06 -0700 (PDT)
Keith Seitz <keiths@redhat.com> wrote:
> On Wed, 4 Sep 2002, Mo DeJong wrote:
>
> > Why would the sources verson differ? I have no idea. This only matters for
> > a VC++ compiled program, so I can't imagine it could effect Insight in any
> > way. The only ChangeLog entry I could find on the subject seems to suggest
> > that the code is not correct.
>
> According to the CVS log, the #define PASCAL line was touched last by irox
> in version 1.5 (2001-09-13). These lines do not appear in version 1.4 of
> the file, so irox must have added them... The ChangeLog for it:
I did some more testing of this PASCAL define and it does seem to be
causing some problems. A `make test` does not pass with PASCAL undefined
and I have a report from a user that it causes failures in Source-Navigator.
The following patch should fix the problem and get the compile working
again under VC++ when the --enable-symbols flag is passed. This patch
should not have any effect on Insight.
thanks
Mo
2002-09-12 Mo DeJong <supermo@bayarea.net>
* win/tclWin32Dll.c (DllMain): Remove unused os
variable since VC++ treats warnings as errors
when compiling with symbols.
* win/tclWinPort.h: Remove undefine of PASCAL
symbol added on 2001-09-12. It caused
crashing problems with sockets.
Index: win/tclWin32Dll.c
===================================================================
RCS file: /cvs/src/src/tcl/win/tclWin32Dll.c,v
retrieving revision 1.4
diff -u -r1.4 tclWin32Dll.c
--- win/tclWin32Dll.c 9 Sep 2001 23:56:10 -0000 1.4
+++ win/tclWin32Dll.c 13 Sep 2002 00:32:23 -0000
@@ -190,8 +190,6 @@
DWORD reason; /* Reason this function is being called. */
LPVOID reserved; /* Not used. */
{
- OSVERSIONINFO os;
-
/* CYGNUS LOCAL */
#ifdef __CYGWIN__0
/* Cygwin requires the impure data pointer to be initialized
Index: win/tclWinPort.h
===================================================================
RCS file: /cvs/src/src/tcl/win/tclWinPort.h,v
retrieving revision 1.6
diff -u -r1.6 tclWinPort.h
--- win/tclWinPort.h 13 Sep 2001 18:27:55 -0000 1.6
+++ win/tclWinPort.h 13 Sep 2002 00:32:23 -0000
@@ -73,10 +73,6 @@
#include <windows.h>
#undef WIN32_LEAN_AND_MEAN
-#ifdef _MSC_VER
-#define PASCAL
-#endif
-
#ifdef BUILD_tcl
# undef TCL_STORAGE_CLASS
# define TCL_STORAGE_CLASS DLLEXPORT