This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Whack last calls to parse_and_eval_address


Hi,

I think these were missed by earlier attempts to remove
parse_and_eval_address. I've also thrown in an obvious free->xfree fix.

Keith

ChangeLog
2002-04-01  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-cmds.c (gdb_load_disassembly): Use string_to_core_addr
        instead of parse_and_eval_address.
	Use xfree instead of free.

Patch
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.54
diff -p -r1.54 gdbtk-cmds.c
*** generic/gdbtk-cmds.c	2002/03/25 16:45:34	1.54
--- generic/gdbtk-cmds.c	2002/04/01 22:26:57
*************** gdb_load_disassembly (ClientData clientD
*** 1672,1678 ****

    /* Now parse the addresses */

!   low = parse_and_eval_address (Tcl_GetStringFromObj (objv[5], NULL));
    orig = low;

    if (objc == 6)
--- 1672,1678 ----

    /* Now parse the addresses */

!   low = string_to_core_addr (Tcl_GetStringFromObj (objv[5], NULL));
    orig = low;

    if (objc == 6)
*************** gdb_load_disassembly (ClientData clientD
*** 1682,1688 ****
  	       paddr_nz (orig), Tcl_GetStringFromObj (objv[5], NULL));
      }
    else
!     high = parse_and_eval_address (Tcl_GetStringFromObj (objv[6], NULL));


    /* Setup the client_data structure, and call the driver function. */
--- 1682,1688 ----
  	       paddr_nz (orig), Tcl_GetStringFromObj (objv[5], NULL));
      }
    else
!     high = string_to_core_addr (Tcl_GetStringFromObj (objv[6], NULL));


    /* Setup the client_data structure, and call the driver function. */
*************** gdbtk_load_asm (ClientData clientData, C
*** 1978,1984 ****
        Tcl_DStringSetLength (&client_data->pc_to_line_prefix, pc_to_line_len);
        Tcl_DStringSetLength (&client_data->line_to_pc_prefix, line_to_pc_len);

!       free(buffer);
      }

    do_cleanups (old_chain);
--- 1978,1984 ----
        Tcl_DStringSetLength (&client_data->pc_to_line_prefix, pc_to_line_len);
        Tcl_DStringSetLength (&client_data->line_to_pc_prefix, line_to_pc_len);

!       xfree (buffer);
      }

    do_cleanups (old_chain);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]