This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] 64 bit address patch


On Thu, 25 Oct 2001, Martin M. Hunt wrote:

> This patch fixes gdb_find_bp_at_addr(),  gdb_set_bp_addr(), and gdb_get_mem()
> to accept 64-bit addresses.  It also fixes broken error messages in those
> functions and gdb_set_bp().

YES YES YES YES YES YES YES YES!!!

I keep forgetting all about this sort of thing, and now that we officially
have string_to_core_addr and core_addr_to_string, there is zero excuse for
not using them.

Just two very minor nits...

> 	* generic/gdbtk-cmds.c (gdb_get_mem): :Use string_to_core_addr
                                            ^^^^

> +gdb_find_bp_at_addr ( ClientData clientData, Tcl_Interp *interp,
                        ^

> +		      int objc, Tcl_Obj *CONST objv[])

Can you tweak the changelog and whack the stray space before checking this
in?

WONDERFUL! Thanks a whole lot. This has been a long time coming. (And
thanks to John Moore and Andrew Cagney for recognizing this and
implementing something that we can use!)

Keith




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]