This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: restoring multi-line breakpoint commands


>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

Keith> Can you give this patch a look over and tell me if you see
Keith> anything glaringly wrong?

The C part of the patch looks fine to me.

Keith> +	  sprintf_append_element_to_obj (obj, "loop_break");

Using sprintf_append_element_to_obj is sort of overkill, but I don't
imagine it matters.

Keith> +    # escape "$", "[", and "]"
Keith> +    if {[info tclversion] >= 8.1} {
Keith> +      set expr {([\[\]\$])}
Keith> +    } else {
Keith> +      set expr {([][$])}
Keith> +    }
Keith> +    regsub -all -- $expr $commands \
Keith> +      {[format "\\%c" [scan {\1} %c x; set x]]} new_commands

This is the part of the patch I don't understand.
Why is this necessary?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]