This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: [PATCH] Improved menu handling with sessions
- To: Tom Tromey <tromey at redhat dot com>
- Subject: Re: [PATCH] Improved menu handling with sessions
- From: Keith Seitz <keiths at cygnus dot com>
- Date: Fri, 3 Aug 2001 14:14:14 -0700 (PDT)
- cc: Insight Maling List <insight at sources dot redhat dot com>
On 3 Aug 2001, Tom Tromey wrote:
> Keith> (gdbtk_tcl_exec_file_display): Save the new session, too.
> Keith> (set_exe_name): Don't bother saving the session here.
> Keith> (_close_file): Save the session here, too.
>
> I don't understand this part of the change.
> Why do this?
It's actually pretty simple... We were doing stuff like:
if {$::gdb_exe_name != ""} { save_sessions }
Side affect: the CURRENT executable is not saved until you EXIT Insight.
The first change (gdbtk_tcl_exec_file, called from the bowels of gdb) adds
the new session to the session list. It shows up in the file menu
immediately. (Maybe this is not correct/ideal?)
The set_exe_name change is now redundant, since gdbtk_tcl_exec_file is
called for all exec file changes.
Finally, we want to save any changes made to the session when we "close"
the session/executable. So any changes we've made get saved.
Got it? (I'm not entirely sure I do.. It took me much longer to figure out
where we need to save the session for this reason or that.0
Keith