This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Another fix to SRC+ASM


I got one more.  This one would cause a ugly stack trace to pop up
on you when changing the function that is being displayed.

It is now fixed in the current sources.

2001-01-17  Fernando Nasser  <fnasser@redhat.com>

        * libremote/srctextwin.itb (_highlightAsmLine): Add missing FILENAME
	parameter.
        (FillAssembly, FillMixed): Pass the FILENAME parameter that is
        needed by the above method.
        * libremote/srctextwin.ith (_highlightAsmLine): Add FILENAME parameter
	to method definition.


-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


Index: srctextwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
retrieving revision 1.17
diff -c -p -r1.17 srctextwin.itb
*** srctextwin.itb	2000/12/07 21:56:25	1.17
--- srctextwin.itb	2001/01/17 23:18:38
*************** body SrcTextWin::FillAssembly {w tagname
*** 1060,1066 ****
    }
    
    # highlight proper line number
!   _highlightAsmLine $win $addr $pc_addr $tagname
  
    display_line $win $current(asm_line)
  }
--- 1060,1066 ----
    }
    
    # highlight proper line number
!   _highlightAsmLine $win $addr $pc_addr $tagname $filename
  
    display_line $win $current(asm_line)
  }
*************** body SrcTextWin::FillMixed {w tagname fi
*** 1119,1125 ****
    }
  
    # highlight proper line number
!   _highlightAsmLine $win $addr $pc_addr $tagname
    display_line $win $current(asm_line)
  }
  
--- 1119,1125 ----
    }
  
    # highlight proper line number
!   _highlightAsmLine $win $addr $pc_addr $tagname $filename
    display_line $win $current(asm_line)
  }
  
*************** body SrcTextWin::FillMixed {w tagname fi
*** 1127,1133 ****
  # METHOD: _highlightAsmLine - highlight the current execution line
  #         in one of the assembly modes
  # ------------------------------------------------------------------
! body SrcTextWin::_highlightAsmLine {win addr pc_addr tagname} {
    global gdb_running
  
    # Some architectures allow multiple instructions in each asm source
--- 1127,1133 ----
  # METHOD: _highlightAsmLine - highlight the current execution line
  #         in one of the assembly modes
  # ------------------------------------------------------------------
! body SrcTextWin::_highlightAsmLine {win addr pc_addr tagname filename} {
    global gdb_running
  
    # Some architectures allow multiple instructions in each asm source
                                                                                
Index: srctextwin.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.ith,v
retrieving revision 1.8
diff -c -p -r1.8 srctextwin.ith
*** srctextwin.ith	2000/12/07 20:14:02	1.8
--- srctextwin.ith	2001/01/17 23:18:37
*************** class SrcTextWin {
*** 131,137 ****
      method _mtime_changed {filename}
      method _initialize_srctextwin {}
      method _clear_cache {}
!     method _highlightAsmLine {win addr pc_addr tagname} {}
  
      proc makeBreakDot {size colorList {image {}}}
    }
--- 131,137 ----
      method _mtime_changed {filename}
      method _initialize_srctextwin {}
      method _clear_cache {}
!     method _highlightAsmLine {win addr pc_addr tagname filename} {}
  
      proc makeBreakDot {size colorList {image {}}}
    }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]