Re: Feature request

[Fernando Nasser <fnasser at cygnus dot com>]

Yes, there are ways to check if things are valid functions but imagine
if the symbol table is too large and the search takes a little longer,
it will add a funny delay on the menu creation.

I know it is not fancy letting the user make the distinction but the feature
is a useful one.

So please check it in.

Thanks for the patch.
Fernando


Tom Tromey wrote:
> 
> >>>>> "Laurent" == Laurent Duperval <laurent.duperval@netergynet.com> writes:
> 
> Laurent>  rc = Tcl_GlobalEval(htmlPtr->interp, Tcl_DStringValue(&cmd));
> 
> Laurent> I'd like to put a breakpoint on Tcl_DStrinvValue by using the
> Laurent> right mouse button. It currently isn't possible. Does anyone
> Laurent> else feel this would be useful?
> 
> I think so.
> Here is a trivial patch to implement it.
> 
> Is there a way to ask gdb whether a given piece of text is the name of
> a function?  If so then it would be nice to make this menu item
> conditional on the text actually naming a function.
> 
> I couldn't find a way to do that.  However if someone else knows
> better, and tells me, I will update the patch.
> 
> If the powers that be like this patch I will check it in.
> 
> 2000-11-21  Tom Tromey  <tromey@cygnus.com>
> 
>         * srctextwin.itb (SrcTextWin::do_source_popup): Added "Set
>         Breakpoint" to popup menu.
> 
> Tom
> 
> Index: gdbtk/library/srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.11
> diff -u -r1.11 srctextwin.itb
> --- srctextwin.itb      2000/10/11 22:37:30     1.11
> +++ srctextwin.itb      2000/11/21 23:10:14
> @@ -1997,6 +1997,8 @@
>           -command [list $this addToWatch $variable]
>         $popups(source) add command -label "Dump Memory at $variable" \
>           -command [list ManagedWin::open MemWin -force -addr_exp $variable]
> +       $popups(source) add command -label "Set Breakpoint at $variable" \
> +         -command [list gdb_cmd "break $variable"]
>         $popups(source) add separator
>        }
>      }

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9