Re: [RFA] 100494 fix

[Larry Smith <larry at smith-house dot org>]

Fernando Nasser wrote:

> Good catch Larry.  But please add a labeled frame around the radiobuttons,
> will you?  The target selection dialog expansion box does look weird with
> two square buttons and two rounds with no explanation.

The "labeledframe" widget does not seem to put up the
label.  Just the frame.  Now the "MoreFrame" labeledframe
widget has the label "Run Options" and that doesn't appear,
either.  No where in the dialog.  Very curious.
Also, according to my [Incr/Tcl from the Ground Up, we
shouldn't be using the labeledframe widget directly
anyway, it's intended to be inherited by other megawidgets.
But it gives no reason for the caution.

I can't execute "iwidgets::labeledframe" from itkwish3.0,
nor any permutation of it I can find.  Any clues what is
going on here?


> "Run method" sounds right for the frame label.
> 
> If you really want to fix this, make sure the option is set to "run" and
> the buttons greyed if the target "exec" is selected.
> 
> Cheers,
> Fernando
> 
> P.S.: Insight patches go to the insight list, not gdb-patches as the people
> that wrote the code watch it more closely and there is a larger group of
> users and contributors in this list that do not subscribe to gdb-patches.
> 
> Larry Smith wrote:
> >
> > The following patch is for 100494, changing a pair of checkbuttons
> > to radiobuttons.  Since the proper behaviour was already enforced
> > this is really only cosmetic, and changes no current control flow.
> >
> > I apologise for being unaware of proper protocol for doing patches
> > on sourceware, this has already been checked in.  I will try to be
> > more circumspect in the future...
> >
> > regards,
> > Larry
> >
> > 2000-10-26  Larry Smith  <lsmith@redhat.com>
> >
> >         * change targetselection.itb: Run Program and Continue From Last Stop
> >         are now radio buttons rather than checkbuttons
> >
> > Index: targetselection.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> > retrieving revision 1.4
> > retrieving revision 1.5
> > diff -u -r1.4 -r1.5
> > --- targetselection.itb 2000/09/12 20:04:11     1.4
> > +++ targetselection.itb 2000/10/26 20:47:57     1.5
> > @@ -488,11 +488,11 @@
> >    checkbutton $frame.load -text {Download Program} -variable $var
> >
> >    set var [pref varname gdb/src/run_cont]
> > -  checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> > +  radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> >      -command [code $this set_run run]
> >
> >    set var [pref varname gdb/src/run_run]
> > -  checkbutton $frame.run -text {Run Program} -variable $var \
> > +  radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> >      -command [code $this set_run cont]
> >
> >    # The after attaching command entry
> 
> --
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9

-- 
 .-.    .-. .---. .---. .-..-. | "Bill Gates is just a monocle
 | |__ / | \| |-< | |-<  >  /  | and a Persian Cat away from
 `----'`-^-'`-'`-'`-'`-' `-'   | being one of the bad guys in a
       My opinions only.       | James Bond movie." -- D Miller