This is the mail archive of the
insight@sourceware.cygnus.com
mailing list for the Insight project.
RFA: Fix editing. [REPOST]
- To: insight at sourceware dot cygnus dot com
- Subject: RFA: Fix editing. [REPOST]
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Thu, 30 Mar 2000 17:01:54 -0500
- Organization: Red Hat , Inc. - Toronto
This fixes another glitch as well.
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@cygnus.com
2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311
Toronto, Ontario M4P 2C9 Fax: 416-482-6299
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/ChangeLog,v
retrieving revision 1.8
diff -c -p -r1.8 ChangeLog
*** ChangeLog 2000/03/10 23:41:46 1.8
--- ChangeLog 2000/03/30 21:59:47
***************
*** 1,3 ****
--- 1,15 ----
+ 2000-03-30 Fernando Nasser <fnasser@totem.to.cygnus.com>
+
+ * variables.tcl (edit): Remove call to close, which caused editing
+ of variables to fail.
+ Note: I don't know why we would need to do this here as it seems
+ that the "delete entry" operation will do that.
+ Perhaps this was to account to some old widget bug.
+ But we cannot call close here because it calls UnEdit,
+ which unsets some of the edit state.
+ (open): Make sure to abort any ongoing edit. This was causing problems
+ when someone tried to expand an structure while editing its pointer.
+
2000-03-10 James Ingham <jingham@leda.cygnus.com>
* targetselection.ith (get_target_list): Should be a proc, since
Index: variables.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/variables.tcl,v
retrieving revision 1.1.1.1
diff -c -p -r1.1.1.1 variables.tcl
*** variables.tcl 2000/02/07 00:19:42 1.1.1.1
--- variables.tcl 2000/03/30 21:59:47
*************** class VariableWin {
*** 425,431 ****
# Find out what the previous entry is
set previous [getPrevious $variable]
- close $variable
$Hlist delete entry $variable
set cmd [format { \
--- 425,430 ----
*************** class VariableWin {
*** 643,648 ****
--- 642,652 ----
global Update
# We must lookup all the variables for this struct
# debug "VariableWin::open $path"
+
+ # Cancel any edits
+ if {[info exists EditEntry]} {
+ UnEdit
+ }
if {!$Running} {
# Do not open disabled paths