This is the mail archive of the
guile@sourceware.cygnus.com
mailing list for the Guile project.
Re: [PATCH] Re: startup speed (or lack thereof)
"C. Ray C." <crayc@tomcramer.org> writes:
>
> Index: libguile/ports.c
> ===================================================================
> RCS file: /cvs/guile/guile/guile-core/libguile/ports.c,v
> retrieving revision 1.99
> diff -u -r1.99 ports.c
> --- ports.c 2000/03/13 22:21:21 1.99
> +++ ports.c 2000/03/17 00:25:45
> @@ -824,6 +824,7 @@
>
> c = *(pt->read_pos++);
>
> +#if 0
> if (c == '\n')
> {
> SCM_INCLINE (port);
> @@ -836,6 +837,7 @@
> {
> SCM_INCCOL (port);
> }
> +#endif
>
> return c;
> }
If removing the line and column number incrementing code really makes
that much performance difference, perhaps we should reconsider doing
this tracking. Or perhaps tracking only the line number and not the
column number would be sufficient; that's all other langauges provide
in error messages, and much of the time the column number is just
noise.
Could you please check what effect taking out only the SCM_INCCOL and
SCM_TABCOL calls (but not the SCM_INCLINE) has on startup performance?
- Maciej