This is the mail archive of the guile@sourceware.cygnus.com mailing list for the Guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

typedef void *




Hi,

I'm just working on my typedef void *SCM; patch, and some of the stuff
I find is dubitable:

unif.c (around line 314):

       case scm_tc7_svect:
             return (SCM_SYMBOLP (prot)
		      && (1 == SCM_LENGTH (prot))
			   && ('s' == SCM_CHARS (prot)[0]));

this might return 0.  I suspect someone forgot a SCM_BOOL. That's what
I'm adding here anyway.

ramap.c is entirely incomprehensible to me. The function raeql is
schizophrenic: it can return SCM_BOOLs, 0 as well as what comes out
ramapc().

Furthermore, throw.c is puzzling to me. Consider the macro JBACTIVE

	     #define JBACTIVE(O) (SCM_CARW (O) & (1L << 16L))

As far as I can tell, this would cause a core dump (referencing the
nilpointer)






-- 

Han-Wen Nienhuys, hanwen@cs.uu.nl ** GNU LilyPond - The Music Typesetter 
      http://www.cs.uu.nl/people/hanwen/lilypond/index.html 




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]