This is the mail archive of the
guile@sourceware.cygnus.com
mailing list for the Guile project.
Re: patches to backtrace.c
- To: Dirk Herrmann <dirk at ida dot ing dot tu-bs dot de>
- Subject: Re: patches to backtrace.c
- From: "Greg J. Badros" <gjb at cs dot washington dot edu>
- Date: 03 Jan 2000 08:21:01 -0800
- Cc: Guile Mailing List <guile at sourceware dot cygnus dot com>
- References: <Pine.LNX.4.21.9912231807420.1847-100000@marvin.ida.ing.tu-bs.de>
Dirk Herrmann <dirk@ida.ing.tu-bs.de> writes:
> Hey, more patches and thoughts -- and it's not christmas yet.
>
> Again, I eliminated redundant SCM_NIMP tests, the patches are appended
> below. The patch of function display_expression is not obviously valid,
> but display_expression is static and only called from one single place,
> where the predicate is always fulfilled. Further, scm_unmemoize performs
> a SCM_NIMP test itself.
Well, I'd rather not make that one change simply because it's making
assumptions about the caller that are not stated clearly, and hard to
enforce reliably (after all, my change was about safety, not
performance). The other two changes I've applied to my copy and will
commit soon.
Thanks!
Greg