This is the mail archive of the guile@cygnus.com mailing list for the guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: dlsym leading underscore fixed


Tim Pierce <twp@skepsis.com> writes:

> > DLSYM_NEEDS_USCORE would be a better name, no?
> 
> I thought so, but I was sticking as closely as possible to hag's
> original fix in SCSH, to reduce the likelihood of typos or other dumb
> goofs.  Remember, DLSYM_NEEDS_USCORE is the opposite of
> DLSYM_ADDS_USCORE, so all of the logic would have to be reversed.

Ah, I see.  Just to be pedantic: dlsym does not add an underscore,
there aren't any underscores in the object file, actually.

> The name of the macro didn't seem to make much difference, so I
> didn't change it.

Agreed.
 
> I've always been sloppy about memory leaks, so thanks for pointing
> this out!  Here's the new sysdep_dynl_func, committed a few minutes
> ago.

Great!  It will give us a "unused variable" warning, which
Jim doesn't like, tho... ;-)