This is the mail archive of the gsl-discuss@sourceware.org mailing list for the GSL project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adding fixed-order Gauss-Legendre integration routines


In that patch I screwed up the order of the GSL_ERROR_NULL vs free
calls within gsl_integration_glfixed_table, e.g.

      w = (double *) malloc(m * sizeof(double));
      if (w == 0)
        {
          GSL_ERROR_NULL ("failed to allocate space for weights",
                  GSL_ENOMEM);
          free(x);
        }

should definitely have their order flipped.  The problem appears once
again just below those lines.

- Rhys


On Tue, Jun 23, 2009 at 11:58 AM, Rhys Ulerich<rhys.ulerich@gmail.com> wrote:
>> Could you redo the patch without the whitespace changes to make it
>> easier to see the actual changes, thanks.
>
> Definitely (attached) ?Didn't know about that git format-patch
> argument until just now...
>
> - Rhys
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]