This is the mail archive of the
gsl-discuss@sourceware.org
mailing list for the GSL project.
Re: [Help-gsl] Submitted patch to add bspline derivative capabilities
Makes sense, and the edits/documentation cleanups look consistent throughout.
There a couple of lingering comments that'll be misleading to anyone
reading the bspline.c file. One final patch, attached, will kill
those.
Thanks,
Rhys
On Mon, Dec 8, 2008 at 3:11 PM, Brian Gough <bjg@network-theory.co.uk> wrote:
> I've added this with some minor changes (I've moved the bspline
> workspace out of the derivative workspace, to avoid any confusion
> about the ownership of the memory -- so the derivative functions take
> the normal bspline workspace and a derivative workspace as arguments).
>
>
remove associated workspace comments
From: Rhys Ulerich <rhys.ulerich@gmail.com>
---
bspline/bspline.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/bspline/bspline.c b/bspline/bspline.c
index 465943b..ab7c742 100644
--- a/bspline/bspline.c
+++ b/bspline/bspline.c
@@ -127,7 +127,7 @@ gsl_bspline_deriv_alloc()
Allocate space for a bspline derivative workspace. The size of the
workspace is O(2k^2)
-Inputs: bspline - gsl_bspline_workspace of the associated bspline
+Inputs: k - spline order (cubic = 4)
Return: pointer to workspace
*/
@@ -208,7 +208,6 @@ gsl_bspline_breakpoint (size_t i, gsl_bspline_workspace * w)
/*
gsl_bspline_free()
Free a gsl_bspline_workspace.
-Any associated gsl_bspline_deriv_workspace should be freed beforehand.
Inputs: w - workspace to free
@@ -228,9 +227,8 @@ gsl_bspline_free (gsl_bspline_workspace * w)
/*
gsl_bspline_deriv_free()
Free a gsl_bspline_deriv_workspace.
-The associated gsl_bspline_workspace should be freed afterwards.
-Inputs: w - workspace to free
+Inputs: dw - workspace to free
Return: none
*/