gnats/gnats ChangeLog client.c cmds.c gnatsd.c ...

[bmanson at sourceware dot cygnus dot com]

CVSROOT:	/cvs/gnats
Module name:	gnats
Changes by:	bmanson@egcs.cygnus.com	99/09/27 21:49:46

Modified files:
	gnats          : ChangeLog client.c cmds.c gnatsd.c pr.h query.c 
	                 query.h 

Log message:
	* pr.h (SearchType): Added DefaultSearchType value.
	
	* query.c (add_query_builtin_field): New function.
	Changed previous callers of add_query_field to use it as
	appropriate.
	(searchTypes): Added entry for DefaultSearchType.
	(pr_match_field): Handle DefaultSearchType.
	
	Boingy boingy boingy.  Can you say "rubber ball on the end of a paddle?"
	
	Comments from query.c:
	
	I don't like having the builtin field stuff either.  However, it
	simplfies query-pr's job, because otherwise it would have to parse
	arguments twice.  The reason is that we don't know the indexes for
	the builtin fields before we've read in and parsed the
	configuration file, and we can't do that until after we've
	processed our arguments to find out if we're a network client (and
	the name of our server etc).
	
	Instead, we refer to the builtin fields directly, and let
	pr_match_field () take care of it later, after we've parsed the
	config file.
	
	We'll probably have to parse arguments twice eventually anyway, but
	let's try to postpone it as long as possible.  One sensible
	alternative is to convert the old-style query options into a
	new-style query expression, then parse that instead.