This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.27.9000-35-g663e7d7
- From: jsm28 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 6 Feb 2018 21:30:22 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.27.9000-35-g663e7d7
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 663e7d784977f6b15c0cab73f754f9f39c9c0c2c (commit)
from 6d7aa2b531088c3a277911534179975eb2622954 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=663e7d784977f6b15c0cab73f754f9f39c9c0c2c
commit 663e7d784977f6b15c0cab73f754f9f39c9c0c2c
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Feb 6 21:29:50 2018 +0000
Only define loff_t for __USE_MISC (bug 14553).
Bug 14553 reports that sys/types.h defines loff_t unconditionally,
despite it not being part of any supported standard. This is
permitted by the POSIX *_t reservation, but as a
quality-of-implementation issue it's still best not to define it
except for __USE_MISC. This patch conditions the definition
accordingly, updating a macro in sysdeps/unix/sysv/linux/sys/quota.h
to use __loff_t so it still works even if __USE_MISC is not defined.
codesearch.debian.net suggests there are quite a lot of loff_t uses
outside glibc, but it might well make sense to change all (few) uses
of loff_t or __loff_t inside glibc to use off64_t or __off64_t
instead, leaving only the definitions, treating this name as
obsolescent.
Tested for x86_64.
[BZ #14553]
* posix/sys/types.h (loff_t): Only define for [__USE_MISC].
* sysdeps/unix/sysv/linux/sys/quota.h (dqoff): Use __loff_t
instead of loff_t.
diff --git a/ChangeLog b/ChangeLog
index a30eeea..c9734c4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2018-02-06 Joseph Myers <joseph@codesourcery.com>
+
+ [BZ #14553]
+ * posix/sys/types.h (loff_t): Only define for [__USE_MISC].
+ * sysdeps/unix/sysv/linux/sys/quota.h (dqoff): Use __loff_t
+ instead of loff_t.
+
2018-02-06 Florian Weimer <fweimer@redhat.com>
[BZ #18023]
diff --git a/posix/sys/types.h b/posix/sys/types.h
index a9e0005..e8d51a1 100644
--- a/posix/sys/types.h
+++ b/posix/sys/types.h
@@ -39,9 +39,8 @@ typedef __u_quad_t u_quad_t;
typedef __fsid_t fsid_t;
# define __u_char_defined
# endif
-#endif
-
typedef __loff_t loff_t;
+#endif
#ifndef __ino_t_defined
# ifndef __USE_FILE_OFFSET64
diff --git a/sysdeps/unix/sysv/linux/sys/quota.h b/sysdeps/unix/sysv/linux/sys/quota.h
index c2a0aaa..23f569e 100644
--- a/sysdeps/unix/sysv/linux/sys/quota.h
+++ b/sysdeps/unix/sysv/linux/sys/quota.h
@@ -114,7 +114,7 @@ struct dqblk
#define dq_btime dq_dqb.dqb_btime
#define dq_itime dq_dqb.dqb_itime
-#define dqoff(UID) ((loff_t)((UID) * sizeof (struct dqblk)))
+#define dqoff(UID) ((__loff_t)((UID) * sizeof (struct dqblk)))
/* Old name for struct if_dqinfo. */
struct dqinfo
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 7 +++++++
posix/sys/types.h | 3 +--
sysdeps/unix/sysv/linux/sys/quota.h | 2 +-
3 files changed, 9 insertions(+), 3 deletions(-)
hooks/post-receive
--
GNU C Library master sources