This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]
GNU C Library master sources branch master updated. glibc-2.26.9000-1056-g6a9dd7a

From: aurel32 at sourceware dot org
To: glibc-cvs at sourceware dot org
Date: 2 Jan 2018 08:57:02 -0000
Subject: GNU C Library master sources branch master updated. glibc-2.26.9000-1056-g6a9dd7a
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  6a9dd7a7c506a215952cd355505bad5b276e42e8 (commit)
      from  b05cb613e7ae507680c8d914b3e788eea782c0d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=6a9dd7a7c506a215952cd355505bad5b276e42e8

commit 6a9dd7a7c506a215952cd355505bad5b276e42e8
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Tue Jan 2 09:55:48 2018 +0100

    Remove alpha specific fmax, fmin to fix sNaN handling [BZ #22660]
    
    Various fmax and fmin function implementations mishandle sNaN
    arguments:
    
    (a) When both arguments are NaNs, the return value should be a qNaN,
    but sometimes it is an sNaN if at least one argument is an sNaN.
    
    (b) Under TS 18661-1 semantics, if either argument is an sNaN then the
    result should be a qNaN (whereas if one argument is a qNaN and the
    other is not a NaN, the result should be the non-NaN argument).
    Various implementations treat sNaNs like qNaNs here.
    
    One way to fix that is to detect the sNaN and add a special case. That
    said there is no FPU instruction to do that, so it requires transfering
    the FP value to an integer register and testing bits. This becomes quite
    complicated so it's probably better to just use the generic versions of
    these functions which just do that through issignaling.
    
    Changelog:
    	[BZ #22660]
    	* sysdeps/alpha/fpu/s_fmax.S: Remove file.
    	* sysdeps/alpha/fpu/s_fmaxf.S: Likewise.
    	* sysdeps/alpha/fpu/s_fmin.S: Likewise.
    	* sysdeps/alpha/fpu/s_fminf.S: Likewise.

diff --git a/ChangeLog b/ChangeLog
index 5452e6f..9e47b81 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2018-01-02  Aurelien Jarno  <aurelien@aurel32.net>
+
+	[BZ #22660]
+	* sysdeps/alpha/fpu/s_fmax.S: Remove file.
+	* sysdeps/alpha/fpu/s_fmaxf.S: Likewise.
+	* sysdeps/alpha/fpu/s_fmin.S: Likewise.
+	* sysdeps/alpha/fpu/s_fminf.S: Likewise.
+
 2018-01-01  Dmitry V. Levin  <ldv@altlinux.org>
 
 	[BZ #22433]
diff --git a/sysdeps/alpha/fpu/s_fmax.S b/sysdeps/alpha/fpu/s_fmax.S
deleted file mode 100644
index 10a45db..0000000
--- a/sysdeps/alpha/fpu/s_fmax.S
+++ /dev/null
@@ -1,52 +0,0 @@
-/* Copyright (C) 2007-2018 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Richard Henderson.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <sysdep.h>
-#include <math_ldbl_opt.h>
-#include <libm-alias-float.h>
-#include <libm-alias-double.h>
-
-        .set noat
-	.set noreorder
-
-	.text
-ENTRY (__fmax)
-	.prologue 0
-
-	cmptun/su	$f16, $f16, $f10
-	cmptun/su	$f17, $f17, $f11
-	fmov		$f17, $f0
-	unop
-
-	trapb
-	fbne		$f10, $ret
-	fmov		$f16, $f0
-	fbne		$f11, $ret
-
-	cmptlt/su	$f16, $f17, $f11
-	trapb
-	fcmovne		$f11, $f17, $f0
-$ret:	ret
-
-END (__fmax)
-
-/* Given the in-register format of single-precision, this works there too.  */
-strong_alias (__fmax, __fmaxf)
-libm_alias_float (__fmax, fmax)
-
-libm_alias_double (__fmax, fmax)
diff --git a/sysdeps/alpha/fpu/s_fmaxf.S b/sysdeps/alpha/fpu/s_fmaxf.S
deleted file mode 100644
index 3c2d62b..0000000
--- a/sysdeps/alpha/fpu/s_fmaxf.S
+++ /dev/null
@@ -1 +0,0 @@
-/* __fmaxf is in s_fmax.c  */
diff --git a/sysdeps/alpha/fpu/s_fmin.S b/sysdeps/alpha/fpu/s_fmin.S
deleted file mode 100644
index 4015a10..0000000
--- a/sysdeps/alpha/fpu/s_fmin.S
+++ /dev/null
@@ -1,52 +0,0 @@
-/* Copyright (C) 2007-2018 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Richard Henderson.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <sysdep.h>
-#include <math_ldbl_opt.h>
-#include <libm-alias-float.h>
-#include <libm-alias-double.h>
-
-        .set noat
-	.set noreorder
-
-	.text
-ENTRY (__fmin)
-	.prologue 0
-
-	cmptun/su	$f16, $f16, $f10
-	cmptun/su	$f17, $f17, $f11
-	fmov		$f17, $f0
-	unop
-
-	trapb
-	fbne		$f10, $ret
-	fmov		$f16, $f0
-	fbne		$f11, $ret
-
-	cmptlt/su	$f17, $f16, $f11
-	trapb
-	fcmovne		$f11, $f17, $f0
-$ret:	ret
-
-END (__fmin)
-
-/* Given the in-register format of single-precision, this works there too.  */
-strong_alias (__fmin, __fminf)
-libm_alias_float (__fmin, fmin)
-
-libm_alias_double (__fmin, fmin)
diff --git a/sysdeps/alpha/fpu/s_fminf.S b/sysdeps/alpha/fpu/s_fminf.S
deleted file mode 100644
index 10ab7fe..0000000
--- a/sysdeps/alpha/fpu/s_fminf.S
+++ /dev/null
@@ -1 +0,0 @@
-/* __fminf is in s_fmin.c  */

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                   |    8 ++++++
 sysdeps/alpha/fpu/s_fmax.S  |   52 -------------------------------------------
 sysdeps/alpha/fpu/s_fmaxf.S |    1 -
 sysdeps/alpha/fpu/s_fmin.S  |   52 -------------------------------------------
 sysdeps/alpha/fpu/s_fminf.S |    1 -
 5 files changed, 8 insertions(+), 106 deletions(-)
 delete mode 100644 sysdeps/alpha/fpu/s_fmax.S
 delete mode 100644 sysdeps/alpha/fpu/s_fmaxf.S
 delete mode 100644 sysdeps/alpha/fpu/s_fmin.S
 delete mode 100644 sysdeps/alpha/fpu/s_fminf.S


hooks/post-receive
-- 
GNU C Library master sources
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]